Dev/t feadeaga error changes#62
Open
FeyiAdeaga wants to merge 42 commits into
Open
Conversation
Test error
…on into org branch T feyiadeaga error clarification
jscalev
requested review from
D1v38om83r,
birukyitbarek,
deeptivaidymsft,
fifuente,
jscalev,
malhotrarohit,
mayankdaruka-msft and
norakoiralamsft
Collaborator
|
might be good to link spec or provide overview of the context in the description of the PR |
alsanmsft
reviewed
Jan 8, 2026
| if ok { | ||
| if status, ok := exitErr.Sys().(syscall.WaitStatus); ok { | ||
| exitCode = status.ExitStatus() | ||
| commandExitCode := exitCode |
Collaborator
There was a problem hiding this comment.
question: why do we differentiate between exitCode and commandExitCode here? What is the meaningful difference?
| f, err := os.OpenFile(dst, os.O_WRONLY|os.O_TRUNC|os.O_CREATE, mode) | ||
| if err != nil { | ||
| return 0, errors.Wrapf(err, "failed to open file for writing: %s", dst) | ||
| return 0, vmextension.NewErrorWithClarificationPtr(constants.FileDownload_OpenFileForWriteFailure, errors.Wrapf(err, "failed to open file for writing: %s", dst)) |
Collaborator
There was a problem hiding this comment.
It may be worth considering differentiating between when a file fails to be open because the path does not exist (since this func doesn't create the directory of destination) versus when a file fails to open for writing for some other reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.